Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypass local DNS on Ubuntu 18.04 #8651

Merged
merged 1 commit into from
May 1, 2020
Merged

Bypass local DNS on Ubuntu 18.04 #8651

merged 1 commit into from
May 1, 2020

Conversation

mikeharder
Copy link
Member

@mikeharder mikeharder commented May 1, 2020 •
edited
Loading

Workaround for actions/runner-images#798

@mikeharder mikeharder requested a review from jeremymeng May 1, 2020 17:41
@mikeharder
Copy link
Member Author

/azp run js - formrecognizer - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chradek
Copy link
Contributor

chradek commented May 1, 2020

This looks interesting! In event-hubs and service bus we started seeing EAI_AGAIN errors instead of ENOTFOUND in some of our tests after the ubuntu update:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=378068&view=logs&j=291aad5e-8689-5983-e460-98c01ad4e5a9&t=38379d61-52f7-5c05-1a40-7595a6abfbd8

I was about to relax our tests but would this change also fix this?

@mikeharder mikeharder merged commit 19c1a04 into Azure:master May 1, 2020
@mikeharder mikeharder deleted the bypass-local-dns branch May 1, 2020 17:52
@mikeharder
Copy link
Member Author

This looks interesting! In event-hubs and service bus we started seeing EAI_AGAIN errors instead of ENOTFOUND in some of our tests after the ubuntu update:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=378068&view=logs&j=291aad5e-8689-5983-e460-98c01ad4e5a9&t=38379d61-52f7-5c05-1a40-7595a6abfbd8

I was about to relax our tests but would this change also fix this?

If they are only failing on Ubuntu 18 I would definitely try again with this change. If they still fail let's investigate further before we just change the test.

@chradek
Copy link
Contributor

chradek commented May 1, 2020

This seems to have fixed the issue. Thanks @mikeharder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeharder @chradek @jeremymeng